This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Fix protobuf gen #56
Merged
Fix protobuf gen #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
force-pushed
the
fix-protobuf-gen
branch
from
92d046c
to
c214976
Compare
|
@C0rby what do you think about this PR? 🤔 |
C0rby
approved these changes
Aug 21, 2020
|
@C0rby I will restart CI on this PR like a hundred times. If there are no failures, I will merge. |
|
@C0rby But you were right, the protoc related steps are not called in the |
|
Yeah, thats so strange.. |
|
5 successful drone runs and 2 with github timeouts... merging now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just checking... related to #30