Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Fix fetching value by identifier and system scope values #66

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Aug 28, 2020

There were several small bugs, now fixed in this PR:

  • fetching a value by identifier (settingID and accountID) didn't return an error if the value was not found
  • saving values for a setting with resource type TYPE_SYSTEM, i.e. global value, which are the same value for all users, were saved with an account uuid set. The account uuid must be omitted on global values so that we are allowed to load them for users with another account uuid.
  • loading global values also didn't work. looks like the implementation was forgotten...

@kulmann kulmann self-assigned this Aug 28, 2020
@kulmann kulmann requested review from C0rby and IljaN August 28, 2020 08:30
@kulmann kulmann merged commit 0df7512 into master Aug 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-fetching-value-by-identifier branch August 28, 2020 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants