This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
[tests only] Mocks for handlers #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
|
why not just start the depending service? |
For unit tests |
|
Imo starting the depending service could be also a valid approach even for "unit-tests" if you see proxy and accounts-service as one unit. Ofcourse this will impact test-runtime etc... |
|
I don't agree. I want to run quick tests in my IDE all the time, so that I can find issues early. Those should not depend on a separate service. |
butonic
approved these changes
Aug 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to mock our service handlers in tests (at the moment needed in ocis-proxy)