This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Use roleIDs from context instead of loading them again #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The roleIDs are coming in as json string from the metadata context and can be extracted using a helper function from the roles middleware. Instead of re-loading those roleIDs again on every permission related request, we now just use the roleIDs from the context. This is also more future-proof for when we decide to move away the role assignments from the settings service into the accounts service.
23 tasks
kulmann
commented
Sep 2, 2020
| @@ -267,7 +264,7 @@ func (g Service) ListRoles(c context.Context, req *proto.ListBundlesRequest, res | |||
| if err != nil { | |||
| return merrors.NotFound(g.id, "%s", err) | |||
| } | |||
| // TODO: only allow to list roles when user has account management permissions | |||
| // TODO: only allow to list roles when user has account/role/... management permissions | |||
There was a problem hiding this comment.
The TODO is tracked here: https://github.com/owncloud/ocis-settings/issues/70
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The roleIDs are coming in as json string from the metadata context and can be extracted
using a helper function from the roles middleware. Instead of re-loading
those roleIDs again on every permission related request, we now just use
the roleIDs from the context. This is also more future-proof for when we
decide to move away the role assignments from the settings service into
the accounts service.