Skip to content

Commit

Permalink
Merge pull request #809 from butonic/fix-konnectd
Browse files Browse the repository at this point in the history
update assets with new default config
  • Loading branch information
butonic authored Nov 5, 2020
2 parents c124102 + 3d1fa00 commit 47a877c
Show file tree
Hide file tree
Showing 7 changed files with 225 additions and 180 deletions.
8 changes: 8 additions & 0 deletions changelog/unreleased/fix-konnectd-build.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Bugfix: Fix konnectd build

Tags: konnectd

We fixed the default config for konnectd and updated the Makefile to include the `yarn install`and `yarn build` steps if the static assets are missing.

https://github.com/owncloud/ocis/pull/809

15 changes: 13 additions & 2 deletions konnectd/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ sync:
clean:
go clean -i ./...
rm -rf $(BIN) $(DIST)
rm -rf node_modules
rm -rf assets/identifier

.PHONY: fmt
fmt:
Expand All @@ -84,12 +86,21 @@ lint:
generate: assets
go generate $(GENERATE)

.PHONY: assets
assets:
# TODO find a docker container with go and yarn so we can properly build assets in ci
#assets: assets/identifier/static assets/identifier/index.html
assets: assets/identifier/static

assets/identifier/static:
mkdir -p assets/identifier/static
curl -o assets/identifier/static/logo.svg ${LOGO_URL}
curl -o assets/identifier/static/favicon.ico ${FAVICON_URL}

assets/identifier/index.html: node_modules
yarn build

node_modules:
yarn install

.PHONY: changelog
changelog:
go run github.com/restic/calens >| CHANGELOG.md
Expand Down
1 change: 1 addition & 0 deletions konnectd/assets/identifier-registration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ clients:
name: ownCloud web app
application_type: web
insecure: yes
trusted: yes
redirect_uris:
- https://localhost:9200/
- https://localhost:9200/oidc-callback.html
Expand Down
119 changes: 1 addition & 118 deletions konnectd/config/identifier-registration.yaml
Original file line number Diff line number Diff line change
@@ -1,118 +1 @@
---

# OpenID Connect client registry.
clients:
- id: phoenix
name: ownCloud web app
application_type: web
insecure: yes
trusted: yes
redirect_uris:
- https://localhost:9200/
- https://localhost:9200/oidc-callback.html
- https://localhost:9200/oidc-silent-redirect.html
- http://localhost:9100/
- http://localhost:9100/oidc-callback.html
- http://localhost:9100/oidc-silent-redirect.html
origins:
- https://localhost:9200
- http://localhost:9100

- id: ocis-explorer.js
name: OCIS Graph Explorer
trusted: yes
application_type: web
insecure: yes

- id: xdXOt13JKxym1B1QcEncf2XDkLAexMBFwiT9j6EfhhHFJhs2KM9jbjTmf8JBXE69
secret: UBntmLjC2yYCeHwsyj73Uwo9TAaecAetRwMw0xYcvNL9yRdLSUi0hUAHfvCHFeFh
name: ownCloud desktop app
application_type: native
insecure: true

- id: e4rAsNUSIUs0lF4nbv9FmCeUkTlV9GdgTLDH1b5uie7syb90SzEVrbN7HIpmWJeD
secret: dInFYGV33xKzhbRmpqQltYNdfLdJIfJ9L5ISoKhNoT9qZftpdWSP71VrpGR9pmoD
name: ownCloud Android app
application_type: native
redirect_uris:
- oc://android.owncloud.com

- id: mxd5OQDk6es5LzOzRvidJNfXLUZS2oN3oUFeXPP8LpPrhx3UroJFduGEYIBOxkY1
secret: KFeFWWEZO9TkisIQzR3fo7hfiMXlOpaqP8CFuTbSHzV1TUuGECglPxpiVKJfOXIx
name: ownCloud iOS app
application_type: native
redirect_uris:
- oc://ios.owncloud.com
- oc.ios://ios.owncloud.com


# - id: playground-trusted.js
# name: Trusted OIDC Playground
# trusted: yes
# application_type: web
# redirect_uris:
# - https://my-host:8509/
# origins:
# - https://my-host:8509

# - id: playground-trusted.js
# name: Trusted Insecure OIDC Playground
# trusted: yes
# application_type: web
# insecure: yes

# - id: client-with-keys
# secret: super
# application_type: native
# redirect_uris:
# - http://localhost
# trusted_scopes:
# - konnect/guestok
# - kopano/kwm
# jwks:
# keys:
# - kty: EC
# use: sig
# kid: client-with-keys-key-1
# crv: P-256
# x: RTZpWoRbjwX1YavmSHVBj6Cy3Yzdkkp6QLvTGB22D0c
# y: jeavjwcX0xlDSchFcBMzXSU7wGs2VPpNxWCwmxFvmF0
# request_object_signing_alg: ES256

# - id: first
# secret: lala
# application_type: native
# redirect_uris:
# - my://app

# - id: second
# secret: lulu
# application_type: native
# redirect_uris:
# - http://localhost

# External authority registry.
authorities:
# - id: my-univention
# name: Univention
# client_id: kopano-konnect
# authority_type: oidc
# jwks:
# keys:
# - kty: EC
# use: sig
# kid: example-key-1
# crv: P-256
# x: RTZpWoRbjwX1YavmSHVBj6Cy3Yzdkkp6QLvTGB22D0c
# y: jeavjwcX0xlDSchFcBMzXSU7wGs2VPpNxWCwmxFvmF0
# default: yes
# authorization_endpoint: https://my-univention/signin/v1/identifier/_/authorize
# response_type: id_token
# scopes:
# - openid
# - profile
# identity_claim_name: preferred_username
# identity_aliases:
# external-user-a: local-user-a
# external-user-b: local-user-b
# identity_alias_required: true
# see ../assets/identifier-registration.yaml
14 changes: 6 additions & 8 deletions konnectd/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -9,25 +9,23 @@ require (
github.com/UnnoTed/fileb0x v1.1.4
github.com/go-chi/chi v4.1.2+incompatible
github.com/gogo/protobuf v1.2.2-0.20190723190241-65acae22fc9d // indirect
github.com/gopherjs/gopherjs v0.0.0-20181103185306-d547d1d9531e // indirect
github.com/gorilla/mux v1.8.0
github.com/gorilla/schema v1.2.0 // indirect
github.com/haya14busa/goverage v0.0.0-20180129164344-eec3514a20b5
github.com/mattn/go-colorable v0.1.2 // indirect
github.com/micro/cli/v2 v2.1.2
github.com/micro/go-micro/v2 v2.9.1
github.com/oklog/run v1.0.0
github.com/olekukonko/tablewriter v0.0.1
github.com/oklog/run v1.1.0
github.com/olekukonko/tablewriter v0.0.4
github.com/openzipkin/zipkin-go v0.2.2
github.com/owncloud/flaex v0.2.0
github.com/owncloud/ocis/ocis-pkg v0.0.0-00010101000000-000000000000
github.com/owncloud/ocis/ocis-pkg v0.0.0-20200918114005-1a0ddd2190ee
github.com/pquerna/cachecontrol v0.0.0-20200921180117-858c6e7e6b7e // indirect
github.com/prometheus/client_golang v1.7.1
github.com/restic/calens v0.2.0
github.com/rs/zerolog v1.19.0
github.com/rs/zerolog v1.20.0
github.com/sirupsen/logrus v1.7.0
github.com/spf13/viper v1.6.3
go.opencensus.io v0.22.4
github.com/spf13/viper v1.7.0
go.opencensus.io v0.22.5
golang.org/x/crypto v0.0.0-20201016220609-9e8e0b390897 // indirect
golang.org/x/net v0.0.0-20201022231255-08b38378de70
golang.org/x/sys v0.0.0-20201022201747-fb209a7c41cd // indirect
Expand Down
Loading

0 comments on commit 47a877c

Please sign in to comment.