Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update eos-base image #1014

Merged
merged 2 commits into from
Dec 3, 2020
Merged

update eos-base image #1014

merged 2 commits into from
Dec 3, 2020

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Dec 3, 2020

Updates

  • EOS Base image from 4.6.5 to 4.8.26

@update-docs
Copy link

update-docs bot commented Dec 3, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar self-assigned this Dec 3, 2020
@micbar
Copy link
Contributor Author

micbar commented Dec 3, 2020

@kulmann I think we don't need a Changelog, because we use it only for testing.

@sonarcloud
Copy link

sonarcloud bot commented Dec 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jnweiger
jnweiger requested changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@jnweiger jnweiger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the numerous mentions of 4.6.5 in the docker-compose*.yml files?
Can we make that an env var?

jnweiger
jnweiger approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@jnweiger jnweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed the second commit. all is well. thanks.

@jnweiger jnweiger merged commit a2cba46 into master Dec 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-eos-base branch December 3, 2020 12:17
ownclouders pushed a commit that referenced this pull request Dec 3, 2020
@jnweiger
commit a2cba46
eb62e70 
Merge: e0e4585 30cb165
Author: Jürgen Weigert <jnweiger@gmail.com>
Date:   Thu Dec 3 13:17:27 2020 +0100

    Merge pull request #1014 from owncloud/update-eos-base

    update eos-base image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnweiger jnweiger jnweiger approved these changes

@butonic butonic Awaiting requested review from butonic

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees

@micbar micbar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micbar @jnweiger