Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] add tests for CLI command uploads sessions #10229

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Oct 3, 2024

Description

This PR adds test for CLI command related to uploads sessions.

Test scenario covered:

Scenario: user lists all upload sessions
Scenario: user lists all upload sessions that are currently postprocessing
Scenario: user lists all upload sessions that are infected by virus
Scenario: user lists all expired upload sessions
Scenario: user cleans all expired upload sessions

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Note: we could write "Then" steps in the form "Then the CLI response should contain only these entries". And that step would check for the required entries, and also check that there are no other entries. And then we would not need the "should not contain" steps.

But it reads nicely like it is - the scenarios are clear about what they are checking for.

Copy link

sonarcloud bot commented Oct 8, 2024

@PrajwolAmatya PrajwolAmatya merged commit 92b298f into master Oct 8, 2024
4 checks passed
@PrajwolAmatya PrajwolAmatya deleted the cli-tests branch October 8, 2024 08:18
ownclouders pushed a commit that referenced this pull request Oct 8, 2024
[tests-only][full-ci] add tests for CLI command uploads sessions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants