Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kept historical resource naming after renaming in activity for shares… #10266

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Oct 8, 2024

… and public links.

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@2403905
Copy link
Contributor Author

2403905 commented Oct 9, 2024

@SagarGi Could you have a look tests error output https://drone.owncloud.com/owncloud/ocis/39752/38/6
There are similar errors related to ... emplate.properties.message mismatch but in the output i see different Received

@2403905
Copy link
Contributor Author

2403905 commented Oct 9, 2024

There are many misleading errors like below that were produced after the code changes because the json schema in a test case contains the redundant required elements.

The pattern "{user} updated {field} for a link {token} on {resource}" expects 4 requered fields, but the jcon schema expects 5 "required": ["field","folder","resource","token","user"]

And the test produce misled error....

ERROR IN A CI
      2. properties.value.items.2.oneOf.1.properties.template.properties.message:
         - Const failed
           Expected: {user} shared {resource} via link
           Received: {user} updated {field} for a link {token} on {resource}
                        "message": {
                          "const": "{user} updated {field} for a link {token} on {resource}"
                        },
                        "variables": {
                          "type": "object",
                          "required": ["field","folder","resource","token","user"],

FYI @SagarGi @individual-it

@2403905 2403905 force-pushed the issue-10210 branch 2 times, most recently from d58ab95 to 9c4566e Compare October 10, 2024 07:25
Copy link

sonarcloud bot commented Oct 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant