Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reva to 063b3db9162b #1091

Merged
merged 12 commits into from
Dec 16, 2020
Merged

Update reva to 063b3db9162b #1091

merged 12 commits into from
Dec 16, 2020

Conversation

refs
Copy link
Member

@refs refs commented Dec 14, 2020 •
edited
Loading

No description provided.

@refs refs changed the title Update reva to v1.4.1-0.20201214141740-063b3db9162b [DO NOT MERGE] Update reva to 063b3db9162b Dec 15, 2020
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/2252/31/6
It got another Could not resolve host: ocis-server
This CI timing problem should be resolved by #1101
In the mean time, I restarted drone CI, it might work when drone agents have all their docker images already cached.

@refs refs force-pushed the feature/update-ocis-public-links branch from a624167 to 8a5aaba Compare December 15, 2020 12:35
@refs refs force-pushed the feature/update-ocis-public-links branch from 8a5aaba to fea44f8 Compare December 15, 2020 13:21
@refs refs changed the title [DO NOT MERGE] Update reva to 063b3db9162b Update reva to 063b3db9162b Dec 16, 2020
@micbar micbar requested a review from kulmann December 16, 2020 10:07
@phil-davis
Copy link
Contributor

The problem is https://drone.owncloud.com/owncloud/ocis/2315/68/7

Cloning into '/srv/app/web'...
+ cp -r /srv/app/web/tests/acceptance/filesForUpload/* /uploads
+ cd /srv/app/web
+ git checkout a96ce8dfa86dc668b620b609830b75dfa4c07a3d
Note: switching to 'a96ce8dfa86dc668b620b609830b75dfa4c07a3d'.

The stupid code copies filesForUpload and then checks out a different commit id, which can have different content in filesForUpload - so now there are inconsistent filesForUpload on the drone agent!!!

@refs
Copy link
Member Author

refs commented Dec 16, 2020

ugh, @phil-davis good catch

@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@refs refs merged commit bf7ae4f into master Dec 16, 2020
@refs refs deleted the feature/update-ocis-public-links branch December 16, 2020 12:43
ownclouders pushed a commit that referenced this pull request Dec 16, 2020
@refs
commit bf7ae4f
535685a 
Merge: 5c54876 9196636
Author: Alex Unger <6905948+refs@users.noreply.github.com>
Date:   Wed Dec 16 13:43:11 2020 +0100

    Merge pull request #1091 from owncloud/feature/update-ocis-public-links
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@micbar micbar micbar approved these changes

@individual-it individual-it Awaiting requested review from individual-it

@phil-davis phil-davis Awaiting requested review from phil-davis

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@refs @phil-davis @kulmann @micbar