Functionality to map home directory to different storage providers #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
requested changes
Jan 7, 2021
There was a problem hiding this comment.
Cool, I love this! AFAICT it might allows us to dynamically register a storage provider for every user and use the userid in the home path.
Just update the usage with an example of what the value could look like so admins get an idea of what they can put there.
The failing UI test is somthing @kulmann or @LukasHirt might have an idea about.
|
Thanks for the review @butonic! Added the example |
|
@butonic can we get this in? |
|
@butonic can you take a look? |
butonic
approved these changes
Jan 29, 2021
ishank011
force-pushed
the
home_mapping
branch
from
bf3a611
to
5f818c6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality to map home directory to different storage providers
cs3org/reva#1142 added a parameter in reva that allows us to redirect /home requests to different storage providers based on a mapping derived from the user attributes, which was previously not possible since we hardcode the /home path for all users. This PR adds the config for that parameter.