Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include runtime as an internal dependency (OCIS-1485) #1483

Merged
merged 6 commits into from
Jan 26, 2021
Merged

Include runtime as an internal dependency (OCIS-1485) #1483

merged 6 commits into from
Jan 26, 2021

Conversation

refs
Copy link
Member

@refs refs commented Jan 25, 2021 •
edited
Loading

What?

Currently, the runtime is under my own private account. For future-proofing we don't want oCIS critical components to depend on external repositories, so we're including refs/pman module as an oCIS package instead.

It supersedes #1481

@update-docs
Copy link

update-docs bot commented Jan 25, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@refs refs mentioned this pull request Jan 25, 2021
Closed
@refs refs changed the title Include runtime as an internal dependency Include runtime as an internal dependency (OCIS-1485) Jan 25, 2021
kulmann
kulmann approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two super tiny nitpicks. Other than that: LGTM 👍

changelog/unreleased/move-pman-to-ocis.md Outdated Show resolved Hide resolved
ocis/pkg/runtime/README.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

fschade
fschade approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@refs refs merged commit 6de9b60 into master Jan 26, 2021
@refs refs deleted the ocis-1485 branch January 26, 2021 10:13
ownclouders pushed a commit that referenced this pull request Jan 26, 2021
@refs
commit 6de9b60
c4ed4f7 
Merge: 8fe2e72 0b14422
Author: Alex Unger <6905948+refs@users.noreply.github.com>
Date:   Tue Jan 26 11:13:53 2021 +0100

    Merge pull request #1483 from owncloud/ocis-1485
@micbar micbar mentioned this pull request Feb 17, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade fschade approved these changes

@IljaN IljaN Awaiting requested review from IljaN

@micbar micbar Awaiting requested review from micbar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@refs @kulmann @fschade