Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

continuous deployment #1489

Merged
merged 2 commits into from
Feb 1, 2021
Merged

continuous deployment #1489

merged 2 commits into from
Feb 1, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jan 26, 2021 •
edited by phil-davis
Loading

Description

Add continuous deployment of our deployment examples to CI.

Related Issue

Motivation and Context

Having up to date test instances.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jan 26, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek force-pushed the continuous_deployment branch 5 times, most recently from a129e2a to f18b4ae Compare January 26, 2021 11:36
@wkloucek wkloucek mentioned this pull request Jan 29, 2021
Merged
@wkloucek wkloucek force-pushed the continuous_deployment branch 2 times, most recently from 6069120 to 2eaea35 Compare January 29, 2021 13:14
@wkloucek wkloucek marked this pull request as ready for review January 29, 2021 13:19
@wkloucek wkloucek changed the title work on continuous deployment continuous deployment Jan 29, 2021
phil-davis
phil-davis reviewed Jan 30, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to fix wherever inital_ssh_key_names is used to be initial_ssh_key_names

deployments/continuous-deployment-config/cs3_users_ocis/latest.yml Outdated Show resolved Hide resolved
deployments/continuous-deployment-config/cs3_users_ocis/released.yml Outdated Show resolved Hide resolved
deployments/continuous-deployment-config/ocis_keycloak/latest.yml Outdated Show resolved Hide resolved
deployments/continuous-deployment-config/ocis_keycloak/released.yml Outdated Show resolved Hide resolved
deployments/continuous-deployment-config/ocis_traefik/latest.yml Outdated Show resolved Hide resolved
deployments/continuous-deployment-config/ocis_traefik/released.yml Outdated Show resolved Hide resolved
@phil-davis phil-davis self-requested a review January 30, 2021 09:12
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit 17c4e9b into master Feb 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the continuous_deployment branch February 1, 2021 09:56
ownclouders pushed a commit that referenced this pull request Feb 1, 2021
@wkloucek
commit 17c4e9b
eb81d7d 
Merge: 85ee5de f3404ab
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon Feb 1 10:56:03 2021 +0100

    Merge pull request #1489 from owncloud/continuous_deployment

    continuous deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@micbar micbar Awaiting requested review from micbar micbar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Continuous Deployment of deployment examples
2 participants
@wkloucek @phil-davis