Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dev docs for settings service #171

Closed
wants to merge 1 commit into from
Closed

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Mar 27, 2020

I filled in more details for the settings concept.

Some things I would like to highlight and get input for:

  • We'll need a role hierarchy when e.g. site admins should be able to overrule user-settings or provide default from a higher role.
  • I personally prefer querying for values and permissions by descriptive identifiers instead of ids. This is especially important since there are not only technical contexts speaking with the settings service. If we'd work with uids we'd need to hardcode them anyway in the code for querying values from the settings service. I made a proposition for referencing permissions and settings in the PR, basically <service>:<settings-bundle>:<settings>:<permission>.
  • We want to avoid a configuration mess where an admin booting up a new service has to assign permissions to the existing roles manually. It could be a good idea to define role archetypes and use them in settings.

Thoughts? @refs @felixboehm @butonic
Might be a good idea to start next sprint with a short meeting to align on this.

@kulmann kulmann self-assigned this Mar 27, 2020
@update-docs
Copy link

update-docs bot commented Mar 27, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann
Copy link
Member Author

kulmann commented Mar 27, 2020

Of course this is built upon #165

@butonic
Copy link
Member

butonic commented Mar 27, 2020

  • I'd like to get around having a role hierarchy. Can you create a concrete example why we cannot do without it. I, too, would like to do the roles and permissions concept properly, but isn't there something we can copy? The ms graph api should have a well thought out permissions concept: https://docs.microsoft.com/de-de/graph/permissions-reference There is also a list of all the available permissions, where maybe the files permissions are most interesting, bit certainly others as well.
  • +1 for descriptive identifiers, but they must be immutable ... we cannot rename them from eg write to update
  • AFAICT we will have a set of default roles to mimic the oc10 permissions of admins, users and anonymous users.

IMO a sync call on tue makes sense!

@micbar micbar mentioned this pull request Mar 30, 2020
50 tasks
@PVince81
Copy link
Contributor

something to re-schedule ?

@butonic
Copy link
Member

butonic commented Jul 1, 2021

bitrottet. reva started introducing scopes for roles and some tastks of the settings service are covered by the reva appprovider, which does not leave much ... needs a new ADR.

@butonic butonic closed this Jul 1, 2021
@wkloucek wkloucek deleted the settings-dev-docs-v2 branch October 6, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants