Update Dependencies on Ocis Extensions [Settings] #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
requested changes
May 11, 2020
go.mod
Outdated
Comment on lines
40
to
47
|
|
||
| // replace github.com/owncloud/ocis-proxy => ../ocis-proxy | ||
|
|
||
| // replace github.com/owncloud/ocis-accounts => ../ocis-accounts | ||
|
|
||
| // replace github.com/owncloud/ocis-settings => ../ocis-settings | ||
|
|
||
| // replace github.com/owncloud/ocis-migration => ../ocis-migration |
There was a problem hiding this comment.
Currently it uses relative replace lines. I doubt this is what you intend.
There was a problem hiding this comment.
just comments, forgot to get rid of them :L
micbar
changed the title
refs
changed the title
IljaN
approved these changes
Jul 14, 2020
|
close as obsolete ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the upcoming release, we have a bunch of open PR that need to be merged. To avoid having local replace statements we're locking
ocis-*extensions to commits on each PR latest version.Ideally we would use branch names, as in:
go get github.com/owncloud/ocis-settings@feature/whateverbut since many PR use feature branches as naming conventions andgo getdoes not support slashes on branch names, we have to stick to the commit hash.This PR should provide with a build-able binary, with the proxy middleware enabled.
To run, OIDC needs to be configured on the proxy config.json:
where
proxy-example.jsoncontents are thisThis PR serves as a testing context for the settings services. There are things that need to be done for a beta release (listed below). After that, all the branches linked in this PR will have to get merged into their respective masters.
Phoenix & SDK
Accounts Service
meaccount uuid to an actual account uuid.Proxy
Settings Service