Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extensions 2020-06-25 #334

Merged
merged 6 commits into from
Jun 29, 2020
Merged

Update extensions 2020-06-25 #334

merged 6 commits into from
Jun 29, 2020

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Jun 25, 2020

more to come later / separately

@PVince81 PVince81 self-assigned this Jun 25, 2020
@PVince81 PVince81 requested a review from butonic June 25, 2020 13:13
@IljaN IljaN self-requested a review June 25, 2020 13:14
@PVince81
Copy link
Contributor Author

what?!

+ make vet
go vet github.com/owncloud/ocis/cmd/ocis github.com/owncloud/ocis/pkg/command github.com/owncloud/ocis/pkg/config github.com/owncloud/ocis/pkg/flagset github.com/owncloud/ocis/pkg/register github.com/owncloud/ocis/pkg/runtime github.com/owncloud/ocis/pkg/tracing github.com/owncloud/ocis/pkg/version
# github.com/cs3org/reva/internal/grpc/services/appprovider
/srv/app/pkg/mod/github.com/cs3org/reva@v0.1.1-0.20200529120551-4f2d9c85d3c9/internal/grpc/services/appprovider/appprovider.go:97:54: req.ResourceInfo undefined (type *"github.com/cs3org/go-cs3apis/cs3/app/provider/v1beta1".OpenRequest has no field or method ResourceInfo)
# github.com/cs3org/reva/internal/grpc/services/gateway
/srv/app/pkg/mod/github.com/cs3org/reva@v0.1.1-0.20200529120551-4f2d9c85d3c9/internal/grpc/services/gateway/appprovider.go:35:45: req.ResourceInfo undefined (type *"github.com/cs3org/go-cs3apis/cs3/app/provider/v1beta1".OpenRequest has no field or method ResourceInfo)
make: *** [Makefile:75: vet] Error 2

probably not updatable until we get ocis-reva as well I guess

@micbar micbar mentioned this pull request Jun 25, 2020
15 tasks
@PVince81 PVince81 marked this pull request as draft June 26, 2020 12:14
@PVince81 PVince81 changed the title Update extensions 2020-05-25 Update extensions 2020-06-25 Jun 26, 2020
@PVince81
Copy link
Contributor Author

added ocis-phoenix 0.8.0

also added ocis-reva from master, needs to be updated to a stable version after release

@PVince81 PVince81 mentioned this pull request Jun 26, 2020
@PVince81 PVince81 force-pushed the update-deps branch 2 times, most recently from 3e2e25e to a991d6f Compare June 26, 2020 15:08
@PVince81
Copy link
Contributor Author

I've cherry-picked #337 to get faster results.

Added ocis-reva 0.7.0 and squashed that bit.

If CI is green we can move forward. Let's hope the Phoenix tests pass now.

@PVince81
Copy link
Contributor Author

more EOS fixing needed it seems #338

@PVince81 PVince81 marked this pull request as ready for review June 29, 2020 08:47
Vincent Petry added 3 commits June 29, 2020 12:26
- ocis-proxy 0.4.0
- ocis-migration 0.2.0
- ocis-reva 0.7.0
- ocis-phoenix 0.8.0
Brings in public link tests
.drone.star Outdated Show resolved Hide resolved
Co-authored-by: Phil Davis <phil@jankaritech.com>
@phil-davis
Copy link
Contributor

The same sort of upload errors are happening in https://cloud.drone.io/owncloud/ocis/737/4/8

Timed out while waiting for element <#files-upload-progress> to not be visible for 20000 milliseconds. - expected "not visible" but got: "visible" (20032ms)
undefined    ✖ failed
      Timed out while waiting for element <#files-upload-progress> to not be visible for 20000 milliseconds. - expected "not visible" but got: "visible" (20032ms)

The upload progress bar does not seem to go away. After 20 seconds it is still there???

I raised PR #342 to update the commit Ids for the test infrastructure to be used from core and phoenix against current OCIS master. That will demonstrate that the very latest test scenarios pass OK. Then the conclusion is that some new dependency change in this PR is causing trouble.

@micbar micbar force-pushed the update-deps branch 10 times, most recently from 32bc2a4 to d3bace7 Compare June 29, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants