Extract storage layer + cs3impl #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
kulmann
force-pushed
the
extract_storage_layer
branch
from
f90a03e
to
52351d2
Compare
IljaN
force-pushed
the
extract_storage_layer
branch
from
100fa2c
to
64bef69
Compare
IljaN
changed the title
refs
suggested changes
Oct 2, 2020
| @@ -99,6 +99,62 @@ func ServerWithConfig(cfg *config.Config) []cli.Flag { | |||
| EnvVars: []string{"ACCOUNTS_JWT_SECRET"}, | |||
| Destination: &cfg.TokenManager.JWTSecret, | |||
| }, | |||
| &cli.StringFlag{ | |||
| Name: "storage-disk-path", | |||
| Value: "", | |||
There was a problem hiding this comment.
No. ;-) We have default values for the CS3 Repo implementation, since it's supposed to be the default. When any other storage is configured (we only have the disk implementation as "other storage") we switch over to that.
TL;DR: Setting a default here would switch back to using the local disk for persisting accounts. We want to use CS3 as default, so we can't have a default disk path.
kulmann
force-pushed
the
extract_storage_layer
branch
from
0744d62
to
e145c3b
Compare
|
@refs thanks for your input! Adjusted the PR and rebased to current master. Could you re-review please? :-) |
refs
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.