Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serve index html #912

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Serve index html #912

merged 2 commits into from
Nov 20, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Nov 20, 2020 •
edited
Loading

It's already the default behaviour of http.FileServer to serve an index.html.

Fixes owncloud/ocis-pkg#63

@kulmann kulmann mentioned this pull request Nov 20, 2020
Closed
C0rby
C0rby approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sonarcloud
Copy link

sonarcloud bot commented Nov 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann kulmann merged commit b8fee3f into master Nov 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the serve-index-html branch November 20, 2020 19:01
ownclouders pushed a commit that referenced this pull request Nov 20, 2020
@kulmann
commit b8fee3f
3e5e2de 
Merge: 2069802 54f9505
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Fri Nov 20 20:00:57 2020 +0100

    Merge pull request #912 from owncloud/serve-index-html

    Serve index html
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@felixboehm felixboehm Awaiting requested review from felixboehm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

static serve index.html for folder path
2 participants
@kulmann @C0rby