Add enable / disable to user listing in accounts UI for admin users

[exalate-issue-sync]

Description

• add a switch to the accounts listing to enable / disable implement as bulk action (button at the top after selection)
• Based on a permission "account management"

DoD

• Tested and deployed
• Extend existing tests

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-277

[exalate-issue-sync]

Benedikt Kulmann commented: Some parts of data management are already implemented in OCIS-117, so it makes sense to build the enable/disable feature on top of that work or wait until it's merged.

[exalate-issue-sync]

Vincent Petry commented: [~pmaier]please attach mock ups

[exalate-issue-sync]

Benedikt Kulmann commented: Possible UI design for enable/disable in mockups: https://www.figma.com/file/7MvPgcwufnZdwSha7f4dOz/ownCloud-Web-App?node-id=3733%3A4890

[exalate-issue-sync]

Benedikt Kulmann commented: Let's discuss it in the design initiative meeting this thursday.

[exalate-issue-sync]

Benedikt Kulmann commented: We decided in the design initiative today, that we'll implement this as bulk action, i.e. checkboxes for selecting users, then buttons for bulk actions (here: enable and disable) appear at the top. Exactly like we're doing it for copy, move, delete in the files app.

Pro:

• ui workflow the user already is familiar with
• no risk of deleting or disabling/enabling users by accident
• quickest way to implement this, as using a switch as ui element would require to apply recent styling in ODS (as pointed out here Align styling of oc-switch current style owncloud-design-system#844)

Con:

• requires two clicks (but a confirmation message like "do you really want to disable user xy" would cause a second click as well)

cc [~pmaier] [~mbarz] [~lhirt] [~pvince81]

[exalate-issue-sync]

Benedikt Kulmann commented: Debugged why accounts still can login after they have been disabled through the new web UI action. Found the reason: we have a cache in ocis-proxy that caches all accounts that have been fetched before in the account_uuis middleware. That cache doesn't get updated when the account itself gets updated. Since we have an in-memory index within ocis-accounts anyway, we can probably get rid of this early optimization.
PR to solve that: owncloud/ocis-proxy#100

[phil-davis]

@kulmann (cc: @jasson99 ) We are currently wondering if we should be running the Provisioning API disableUser and enableUser acceptance tests in OCIS.

Is the Provisioning API enable/disable planned to work?
(If so, then we will leave the test scenarios running in OCIS, and they will start passing some day)

[exalate-issue-sync]

Benedikt Kulmann commented: At the moment this is blocked on CI due to a broken test. https://github.com/owncloud/ocis/issues/532