This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Add enable and disable batch actions #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
LukasHirt
force-pushed
the
feature/batch-actions
branch
from
ce4eca0
to
accc586
Compare
kulmann
suggested changes
Sep 7, 2020
There was a problem hiding this comment.
Things I noticed in the UI:
- we should add a
clear selectionlink like in the files app - when you select all users, switch to the files app and come back to the accounts app, the selection of the rows is cleared, but the
select allcheckbox is still checked and the bulk action row (6 selected usersand the actions dropdown) is still visible. One funny thing about this: if you select one more user (which is possible because the checkboxes are not checked), the bulk action row goes to 7 selected users, while we only have 6, and theselect allcheckbox is unchecked (because the selection doesn't equal the overall number of users anymore)
Also, see comments :-)
Most of the code looks really good already, thank you!
LukasHirt
force-pushed
the
feature/batch-actions
branch
from
e56d130
to
7cd554b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've added batch actions into the accounts listing to provide options to enable and disable accounts.
Related issues
Screenshots