Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second factor verification page mentions google authenticator #41

Closed
SergioBertolinSG opened this issue Jan 15, 2018 · 5 comments
Closed

Second factor verification page mentions google authenticator #41

SergioBertolinSG opened this issue Jan 15, 2018 · 5 comments
Labels
enhancement
Milestone
0.4.4

Comments

@SergioBertolinSG
Copy link
Contributor

screen shot 2018-01-15 at 13 01 20

There is no need to use Google Authenticator with this app, there are other apps. For example FreeOTP.

What do you think @pmaier1
@SergioBertolinSG SergioBertolinSG added this to the QA milestone Jan 15, 2018
@pmaier1
Copy link
Contributor

pmaier1 commented Jan 16, 2018 •
edited
Loading

Good point. For the sake of clarity we should have a more general wording here 👍 Either there is a more general name for services like Google Authenticator or we could remove it and instead just say "Time-based one-time password".

@SergioBertolinSG
Copy link
Contributor Author

It this a blocker for 0.4.4 release?

@pmaier1
Copy link
Contributor

pmaier1 commented Jan 16, 2018

It this a blocker for 0.4.4 release?

No. But should be easy to change that text, right?

@SergioBertolinSG
Copy link
Contributor Author

Yes, I've made the PR:

#43

@pmaier1
Copy link
Contributor

pmaier1 commented Jan 16, 2018

Thanks! It's merged.

@pmaier1 pmaier1 closed this as completed Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.4.4
Development

No branches or pull requests
2 participants
@SergioBertolinSG @pmaier1