Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed title in 2FA login #43

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Changed title in 2FA login #43

merged 1 commit into from
Jan 16, 2018

Conversation

SergioBertolinSG
Copy link
Contributor

Changed title in login view.

@SergioBertolinSG SergioBertolinSG added this to the QA milestone Jan 16, 2018
@SergioBertolinSG SergioBertolinSG self-assigned this Jan 16, 2018
@SergioBertolinSG SergioBertolinSG mentioned this pull request Jan 16, 2018
Closed
PVince81
PVince81 approved these changes Jan 16, 2018
View reviewed changes
Copy link

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 555f55c into release/0.4.4 Jan 16, 2018
@PVince81 PVince81 deleted the changed-title-login branch January 16, 2018 11:38
@karakayasemi
Copy link
Contributor

Why do not we merge it into master branch also?

@SergioBertolinSG
Copy link
Contributor Author

SergioBertolinSG commented Jan 17, 2018 •
edited
Loading

@karakayasemi Sorry, we are following a process and it may not be clear:

  1. Create release/version branch.
  2. Add all the fixes found in testing to release/version branch.
  3. Release the app version.
  4. Merge release/version branch with master.

@karakayasemi
Copy link
Contributor

okay, thank you for clarification. That is why I asked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@pmaier1 pmaier1 Awaiting requested review from pmaier1

Assignees

@SergioBertolinSG SergioBertolinSG

Labels
None yet
Projects
None yet
Milestone
0.4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioBertolinSG @karakayasemi @PVince81