Skip to content

Commit

Permalink
Update expected to failure file to match its correct issue
Browse files Browse the repository at this point in the history
  • Loading branch information
@SwikritiT
SwikritiT committed Mar 4, 2021
1 parent 30fda0c commit 053c6b6
Show file tree
Hide file tree
Showing 7 changed files with 78 additions and 376 deletions.
132 changes: 62 additions & 70 deletions tests/acceptance/expected-failures-with-ocis-server-owncloud-storage.md
View file

Large diffs are not rendered by default.

62 changes: 2 additions & 60 deletions tests/acceptance/features/webUIResharing/reshareUsers.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Feature: Resharing shared files with different permissions
| Advanced permissions | Advanced permissions | update | update | read, update |
| Advanced permissions | Editor | delete, create, update | | read, delete, update, create |

@issue-4193
@issue-4193 @issue-ocis-1743
Scenario Outline: share a received folder with another user with same permissions(including share permissions) and check if the user is displayed in collaborators list for original owner
Given user "Brian" has shared folder "simple-folder" with user "Alice" with "<permissions>" permissions
And user "Alice" has accepted the share "simple-folder" offered by user "Brian"
Expand Down Expand Up @@ -132,42 +132,6 @@ Feature: Resharing shared files with different permissions
| Advanced permissions | Advanced permissions | update, share | share, update | read, update, share |
| Advanced permissions | Editor | delete, share, create, update | , | read, share, delete, update, create |

@skipOnOC10 @issue-ocis-717
#after fixing the issue delete this scenario and use the one above by deleting the @skipOnOCIS tag there
Scenario Outline: share a received folder with another user with same permissions(including share permissions) and check if the user is displayed in collaborators list for original owner
Given user "Brian" has shared folder "simple-folder" with user "Alice" with "<permissions>" permissions
And user "Alice" has accepted the share "simple-folder" offered by user "Brian"
And user "Alice" has logged in using the webUI
And the user opens folder "Shares" using the webUI
When the user shares folder "simple-folder" with user "Carol King" as "<role>" with permissions "<collaborators-permissions>" using the webUI
And user "Carol" accepts the share "simple-folder" offered by user "Alice" using the sharing API
And the user re-logs in as "Brian" using the webUI
Then user "Carol King" should be listed as "<displayed-role>" in the collaborators list for folder "simple-folder" on the webUI
And custom permissions "<displayed-permissions>" should be set for user "Carol King" for folder "simple-folder" on the webUI
And user "Alice Hansen" should be listed as "<displayed-role>" in the collaborators list for folder "simple-folder" on the webUI
And custom permissions "<displayed-permissions>" should be set for user "Alice Hansen" for folder "simple-folder" on the webUI
And user "Carol" should have received a share with these details:
| field | value |
| uid_owner | Alice |
| share_with | Carol |
| file_target | /simple-folder |
| item_type | folder |
| permissions | <permissions> |
And user "Alice" should have received a share with these details:
| field | value |
| uid_owner | Brian |
| share_with | Alice |
| file_target | /simple-folder |
| item_type | folder |
| permissions | <permissions> |
Examples:
| role | displayed-role | collaborators-permissions | displayed-permissions | permissions |
| Viewer | Viewer | , | , | read |
| Editor | Editor | , | , | all |
| Advanced permissions | Advanced permissions | create | create | read, create |
| Advanced permissions | Advanced permissions | update | update | read, update |
| Advanced permissions | Editor | delete, create, update | , | read, delete, update, create |

@issue-4193
Scenario: share a folder with another user with share permissions and reshare without share permissions to different user, and check if user is displayed for original sharer
Given user "Brian" has shared folder "simple-folder" with user "Alice" with "read, share" permissions
Expand Down Expand Up @@ -285,29 +249,7 @@ Feature: Resharing shared files with different permissions
| simple-folder |
| lorem.txt |


Scenario: User is allowed to reshare a file/folder with the equivalent received permissions, and collaborators should not be listed for the receiver
Given user "Brian" has shared folder "simple-folder" with user "Alice" with "read, share, delete" permissions
And user "Alice" has accepted the share "simple-folder" offered by user "Brian"
And user "Alice" has logged in using the webUI
And the user opens folder "Shares" using the webUI
When the user shares folder "simple-folder" with user "Carol King" as "Advanced permissions" with permissions "share, delete" using the webUI
And user "Carol" accepts the share "simple-folder" offered by user "Alice" using the sharing API
And the user re-logs in as "Carol" using the webUI
And the user opens folder "Shares" using the webUI
And the user opens the share dialog for folder "simple-folder" using the webUI
Then the current collaborators list should have order "Brian Murphy,Carol King"
And user "Brian Murphy" should be listed as "Owner" reshared through "Alice Hansen" in the collaborators list on the webUI
And user "Carol" should have received a share with these details:
| field | value |
| uid_owner | Alice |
| share_with | Carol |
| file_target | /Shares/simple-folder |
| item_type | folder |
| permissions | share, delete, read |

@skipOnOC10 @issue-ocis-717
#after fixing the issue delete this scenario and use the one above by deleting the @skipOnOCIS tag there
@issue-ocis-1743
Scenario: User is allowed to reshare a file/folder with the equivalent received permissions, and collaborators should not be listed for the receiver
Given user "Brian" has shared folder "simple-folder" with user "Alice" with "read, share, delete" permissions
And user "Alice" has accepted the share "simple-folder" offered by user "Brian"
Expand Down
57 changes: 3 additions & 54 deletions ...tance/features/webUISharingFilePermissionMultipleUsers/shareFileWithMultipleUsers.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Feature: Sharing files with multiple internal users with different permissions
| Alice |
| Brian |

@issue-ocis-717
@issue-ocis-1743
Scenario Outline: share a file with multiple users with different roles and permissions
Given these users have been created with default attributes:
| username |
Expand All @@ -24,9 +24,9 @@ Feature: Sharing files with multiple internal users with different permissions
And the user selects the following collaborators for the share as "<role>" with "<extra-permissions>" permissions:
| collaborator | type |
| Regular User | user |
| Brian Murphy | user |
| Brian Murphy | user |
| Carol King | user |
| David Lopez | user |
| David Lopez | user |
And the user removes "David Lopez" as a collaborator from the share
And the user removes "Regular User" as a collaborator from the share
And the user shares with the selected collaborators
Expand Down Expand Up @@ -62,54 +62,3 @@ Feature: Sharing files with multiple internal users with different permissions
| Advanced permissions | Viewer | share | , | read, share |
| Advanced permissions | Advanced permissions | update | update | read, update |
| Advanced permissions | Editor | share, update | , | read, update, share |

@skipOnOC10 @issue-ocis-717
#after fixing the issue delete this scenario and use the one above by deleting the @skipOnOCIS tag there
Scenario Outline: share a file with multiple users with different roles and permissions
Given these users have been created with default attributes:
| username |
| user0 |
| Carol |
| David |
And user "Alice" has logged in using the webUI
When the user opens the share dialog for file "lorem.txt" using the webUI
And the user opens the share creation dialog in the webUI
And the user selects the following collaborators for the share as "<role>" with "<extra-permissions>" permissions:
| collaborator | type |
| Regular User | user |
| Brian Murphy | user |
| Carol King | user |
| David Lopez | user |
And the user removes "David Lopez" as a collaborator from the share
And the user removes "Regular User" as a collaborator from the share
And the user shares with the selected collaborators
And user "Brian" accepts the share "lorem.txt" offered by user "Alice" using the sharing API
And user "Carol" accepts the share "lorem.txt" offered by user "Alice" using the sharing API
Then custom permissions "<displayed-permissions>" should be set for user "Brian Murphy" for file "lorem.txt" on the webUI
And custom permissions "<displayed-permissions>" should be set for user "Carol King" for file "lorem.txt" on the webUI
And user "Brian Murphy" should be listed as "<displayed-role>" in the collaborators list for file "lorem.txt" on the webUI
And user "Carol King" should be listed as "<displayed-role>" in the collaborators list for file "lorem.txt" on the webUI
And user "Brian" should have received a share with these details:
| field | value |
| uid_owner | Alice |
| share_with | Brian |
| file_target | /Shares/lorem.txt |
| item_type | file |
| permissions | <actual-permissions> |
And user "Carol" should have received a share with these details:
| field | value |
| uid_owner | Alice |
| share_with | Carol |
| file_target | /Shares/lorem.txt |
| item_type | file |
| permissions | <actual-permissions> |
But user "Regular User" should not be listed in the collaborators list on the webUI
And as "user0" file "/Shares/lorem.txt" should not exist
And user "David Lopez" should not be listed in the collaborators list on the webUI
And as "David" file "/Shares/lorem.txt" should not exist
Examples:
| role | displayed-role | extra-permissions | displayed-permissions | actual-permissions |
| Viewer | Viewer | , | , | read |
| Editor | Editor | , | , | read, update |
| Advanced permissions | Viewer | , | , | read |
| Advanced permissions | Editor | update | , | read, update |
2 changes: 1 addition & 1 deletion ...rAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Feature: Sharing folders with multiple internal users using advanced permissions
| Alice |
| Brian |


@issue-ocis-1743
Scenario Outline: share a folder with multiple users using role as advanced permissions role and different extra permissions
Given these users have been created with default attributes:
| username |
Expand Down
59 changes: 2 additions & 57 deletions ...e/features/webUISharingFolderPermissionMultipleUsers/shareFolderWithMultipleUsers.feature
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@issue-ocis-717

Feature: Sharing folders with multiple internal users with different permissions
As a user
I want to set different permissions on shared folders with other users
Expand All @@ -12,7 +12,7 @@ Feature: Sharing folders with multiple internal users with different permissions
| Alice |
| Brian |


@issue-ocis-1743
Scenario Outline: share a folder with multiple users with different roles and permissions
Given these users have been created with default attributes:
| username |
Expand Down Expand Up @@ -63,58 +63,3 @@ Feature: Sharing folders with multiple internal users with different permissions
| Advanced permissions | Viewer | share | , | read, share |
| Advanced permissions | Advanced permissions | delete, update, create | delete, update, create | read, delete, update, create |
| Advanced permissions | Editor | share, delete, update, create | , | all |

@skipOnOC10
#after fixing the issue delete this scenario and use the one above by deleting the @skipOnOCIS tag there
Scenario Outline: share a folder with multiple users with different roles and permissions
Given these users have been created with default attributes:
| username |
| user0 |
| Carol |
| David |
And user "Alice" has logged in using the webUI
When the user opens the share dialog for folder "simple-folder" using the webUI
And the user opens the share creation dialog in the webUI
And the user selects the following collaborators for the share as "<role>" with "<extra-permissions>" permissions:
| collaborator | type |
| Regular User | user |
| Brian Murphy | user |
| Carol King | user |
| David Lopez | user |
And the user removes "David Lopez" as a collaborator from the share
And the user removes "Regular User" as a collaborator from the share
And the user shares with the selected collaborators
And user "Brian" accepts the share "simple-folder" offered by user "Alice" using the sharing API
And user "Carol" accepts the share "simple-folder" offered by user "Alice" using the sharing API
Then custom permissions "<displayed-permissions>" should be set for user "Brian Murphy" for folder "simple-folder" on the webUI
And custom permissions "<displayed-permissions>" should be set for user "Carol King" for folder "simple-folder" on the webUI
And user "Brian Murphy" should be listed as "<displayed-role>" in the collaborators list for folder "simple-folder" on the webUI
And user "Carol King" should be listed as "<displayed-role>" in the collaborators list for folder "simple-folder" on the webUI
And user "Brian" should have received a share with these details:
| field | value |
| uid_owner | Alice |
| share_with | Brian |
| file_target | /Shares/simple-folder |
| item_type | folder |
| permissions | <actual-permissions> |
And user "Carol" should have received a share with these details:
| field | value |
| uid_owner | Alice |
| share_with | Carol |
| file_target | /Shares/simple-folder |
| item_type | folder |
| permissions | <actual-permissions> |
But user "Regular User" should not be listed in the collaborators list on the webUI
And as "user0" folder "simple-folder (2)" should not exist
And user "David Lopez" should not be listed in the collaborators list on the webUI
And as "David" folder "simple-folder (2)" should not exist
Examples:
| role | displayed-role | extra-permissions | displayed-permissions | actual-permissions |
# | Viewer | Viewer | share | share | read, share |
| Viewer | Viewer | , | , | read |
# | Editor | Editor | share | share | all |
| Editor | Editor | , | , | read, update, delete, create |
| Advanced permissions | Viewer | , | , | read |
# | Advanced permissions | Viewer | share | share | read, share |
| Advanced permissions | Editor | delete, update, create | , | read, delete, update, create |
# | Advanced permissions | Editor | share, delete, update, create | share | all |
29 changes: 2 additions & 27 deletions tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Feature: Sharing files and folders with internal users
| Alice |
| Brian |

@yetToImplement @smokeTest @issue-ocis-717
@yetToImplement @smokeTest @issue-ocis-1743
Scenario Outline: share a file & folder with another internal user
Given user "Brian" has logged in using the webUI
When the user shares folder "simple-folder" with user "Alice Hansen" as "<set-role>" using the webUI
Expand Down Expand Up @@ -55,7 +55,7 @@ Feature: Sharing files and folders with internal users
| Editor | Editor | read,update,create,delete,share | read,update,share |
| Advanced permissions | Advanced permissions | read | read |

@issue-ocis-717
@issue-ocis-1743
Scenario Outline: change the collaborators of a file & folder
Given user "Brian" has logged in using the webUI
And user "Brian" has shared folder "/simple-folder" with user "Alice" with "<initial-permissions>" permissions
Expand All @@ -79,31 +79,6 @@ Feature: Sharing files and folders with internal users
| read,share | Advanced permissions | Viewer | read,share |
| all | Advanced permissions | Editor | all |

@skipOnOC10 @issue-ocis-717
#after fixing the issue delete this scenario and use the one above by deleting the @skipOnOCIS tag there
Scenario Outline: change the collaborators of a file & folder
Given user "Brian" has logged in using the webUI
And user "Brian" has shared folder "/simple-folder" with user "Alice" with "<initial-permissions>" permissions
And user "Alice" has accepted the share "simple-folder" offered by user "Brian"
When the user changes the collaborator role of "Alice Hansen" for folder "simple-folder" to "<set-role>" using the webUI
# check role without reloading the collaborators panel, see issue #1786
Then user "Alice Hansen" should be listed as "<expected-role>" in the collaborators list on the webUI
# check role after reopening the collaborators panel
And user "Alice Hansen" should be listed as "<expected-role>" in the collaborators list for folder "simple-folder" on the webUI
And user "Alice" should have received a share with these details:
| field | value |
| uid_owner | Brian |
| share_with | Alice |
| file_target | /Shares/simple-folder |
| item_type | folder |
| permissions | <expected-permissions> |
Examples:
| initial-permissions | set-role | expected-role | expected-permissions |
| read,update,create | Viewer | Viewer | read |
| read | Editor | Editor | read,update,create,delete |
| read | Advanced permissions | Viewer | read |
| read,update,create,delete | Advanced permissions | Editor | read,update,create,delete |

@skip @issue-4102
Scenario: share a file with another internal user who overwrites and unshares the file
Given user "Brian" has logged in using the webUI
Expand Down
Loading

0 comments on commit 053c6b6

Please sign in to comment.