Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI fail when warnings in console #2728

Closed
PVince81 opened this issue Dec 17, 2019 · 6 comments
Closed

Make CI fail when warnings in console #2728

PVince81 opened this issue Dec 17, 2019 · 6 comments
Labels

Comments

@PVince81
Copy link
Contributor

We should trigger a CI failure whenever we detect warnings in the browser console at the end of any successful test.

If this is too complicated to do technically, then at least add scenarios for the main pages like the files app, public link page and files drop.

This way we can catch these earlier as they could be signs of regressions.

@individual-it @DeepDiver1975 @LukasHirt

@PVince81
Copy link
Contributor Author

Context: we had ODS updates recently that introduced new required attributes but CI still passed.
Ref to a PR of mine that fixes this kind of warnings: #2727

@PVince81
Copy link
Contributor Author

I found this API to access log entries: https://stackoverflow.com/a/53780970

@individual-it
Copy link
Member

we could have a check in the AfterScenario hook

@PVince81
Copy link
Contributor Author

I managed to come up with something that works: #2729

@PVince81 PVince81 self-assigned this Dec 17, 2019
@PVince81 PVince81 removed their assignment Oct 9, 2020
@pascalwengerter
Copy link
Contributor

We should take another look at this after #5194 got merged

@pascalwengerter
Copy link
Contributor

Closing as not relevant anymore. We usually check the console for warnings&errors when doing PR reviews and releases

Also @ScharfViktor maybe take note of this idea for improving smoke tests in the future. Not pressing from my POV, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants