Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch console errors in CI #2729

Closed
wants to merge 1 commit into from
Closed

Catch console errors in CI #2729

wants to merge 1 commit into from

Conversation

PVince81
Copy link
Contributor

Description

Catch console errors in CI at the end of every test.
If any errors are found, the test will fail and the offending messages are printed out.

Related Issue

Fixes #2728

Motivation and Context

How Has This Been Tested?

Manual test with master, since we have console errors there already...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@PVince81 PVince81 self-assigned this Dec 17, 2019
@PVince81 PVince81 mentioned this pull request Dec 17, 2019
Closed
@PVince81
Copy link
Contributor Author

PVince81 commented Dec 17, 2019 •
edited by LukasHirt
Loading

individual-it
individual-it previously approved these changes Dec 17, 2019
View reviewed changes
@PVince81
Copy link
Contributor Author

PVince81 commented Dec 17, 2019 •
edited
Loading

To illustrate how it looks like now:

Screenshot_20191217_161221

@skshetry
Copy link
Member

@PVince81, there's conflict as I just refactored nightwatch.conf.js and merged two setup-* to only have single entry-points.

@skshetry
Copy link
Member

skshetry commented Jan 1, 2020

@PVince81, #2756 implemented most of the changes from this PR. I have adjusted this PR to fail the tests when there is console.error.

@LukasHirt
Copy link
Contributor

Rebased PR after #2726 has been merged.

@individual-it
Copy link
Member

the missing avatar seems to be an issue: 3:25:01 PM - SEVERE - http://owncloud/remote.php/dav/avatars/user1/128.png - Failed to load resource: the server responded with a status of 404 (Not Found)

@PVince81
Copy link
Contributor Author

PVince81 commented Feb 5, 2020

Raised #2977 for the avatar errors

@PVince81
Copy link
Contributor Author

PVince81 commented Feb 5, 2020

Rebased and adjusted as follows:

  • SEVERE log entries are always retrieved.
  • in case of test failure, also include DEBUG messages
  • if at least one message was found, fail the test

@PVince81 PVince81 dismissed individual-it’s stale review February 6, 2020 16:50

everything has changed since last time

@PVince81
Copy link
Contributor Author

PVince81 commented Sep 3, 2020

if we still need this, this will need to be redone

@PVince81 PVince81 closed this Sep 3, 2020
@pascalwengerter pascalwengerter deleted the tests-catch-console-errors branch May 10, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it left review comments

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@PVince81 PVince81

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make CI fail when warnings in console
4 participants
@PVince81 @skshetry @LukasHirt @individual-it