Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send avatar requests in the background #4973

Closed
ishank011 opened this issue Apr 15, 2021 · 5 comments · Fixed by #5073 or #5194
Closed

Send avatar requests in the background #4973

ishank011 opened this issue Apr 15, 2021 · 5 comments · Fixed by #5073 or #5194

Comments

@ishank011
Copy link

ishank011 commented Apr 15, 2021

When the 'Shared with me' or 'Shared with others' tab is opened, web sends requests to the /remote.php/dav/avatars/$username/128.png to get the profile pictures for the collaborators. While it definitely improves the UX, it significantly increases the latency.

@pascalwengerter
Copy link
Contributor

Great feedback, thanks!

For anyone looking into this:

@pascalwengerter pascalwengerter added the Topic:good-first-issue beginner friendly task label Apr 15, 2021
@exalate-issue-sync
Copy link

Pascal Wengerter commented: WIP PoC to be found here: owncloud/owncloud-design-system#1242

Discussed with [~bkulmann] and [~dchristofas] that we may have to implement some backend functionality around avatar images to further improve loading performance

@exalate-issue-sync
Copy link

Florian Schade commented: the lazy loaing of images is only one side of the whole task, in our case we need to get the pre-signed url even before we able to paint the actual image to the ui.

This is done in a async way right now, and stops the rendering of the whole table. Is fixed in: #5073

@ishank011
Copy link
Author

Still happens in foreground. Tested with e229c60

@ishank011 ishank011 reopened this May 21, 2021
@micbar
Copy link
Contributor

micbar commented May 31, 2021

@ishank011 did you test with a local build?

#5073 is not yet released. It is part of v3.2.0-rc2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants