This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
[WIP] Add custom vue-avatar library & update component + snapshot #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
pascalwengerter
changed the title
pascalwengerter
force-pushed
the
25042021_custom-vue-avatar
branch
from
9630995
to
d60e4c9
Compare
|
pascalwengerter/vue-avatar#21042021_add-lazy-img-loading needs dist to be part of repo |
fschade
force-pushed
the
25042021_custom-vue-avatar
branch
from
38b8255
to
4172710
Compare
fschade
approved these changes
Apr 27, 2021
pascalwengerter
force-pushed
the
25042021_custom-vue-avatar
branch
from
4172710
to
9f46205
Compare
pascalwengerter
force-pushed
the
25042021_custom-vue-avatar
branch
from
9f46205
to
91bf29a
Compare
kulmann
reviewed
May 4, 2021
| @@ -1,9 +1,24 @@ | |||
| <template> | |||
| <img | |||
| v-if="src.length > 0" | |||
There was a problem hiding this comment.
There is an issue: if the image fails to load we also need to fall back to the avatar component.
|
Closed as outdated, will open a PR that supersedes this soon |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to check out the changes locally. We perhaps should merge my repo to it's master branch and do a proper release before introducing it to
web