Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request cancelation #5163

Closed
exalate-issue-sync bot opened this issue May 28, 2021 · 2 comments · Fixed by #5194
Closed

Request cancelation #5163

exalate-issue-sync bot opened this issue May 28, 2021 · 2 comments · Fixed by #5194
Labels
Category:Defect Existing functionality is not working as expected Priority:p1-urgent Consider a hotfix release with only that fix Topic:Hardening Topic:Performance Type:Bug Something isn't working

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented May 28, 2021 •
edited by kulmann
Loading

Description

While quickly navigation through the ui, it can happen that requests from other routes are still ongoing.

This could lead to problems because the old request can mutate the state (VueX) even if its not intended anymore.

Steps to reproduce

  • open files app
  • open browser network panel
  • click all files very fast multiple times
  • look at ongoing requests in network panel

Story

as a user i expect that old requests get canceled if they not needed anymore.

Acceptance criteria

  • old unnecessary requests get canceled after lefing a route
  • async requests can be canceled

Ideas

  • fetch abortController
  • generator functions
@exalate-issue-sync exalate-issue-sync bot added Category:Defect Existing functionality is not working as expected p2-high Priority:p2-high Escalation, on top of current planning, release blocker Topic:Hardening Topic:Performance Type:Bug Something isn't working labels May 28, 2021
@fschade
Copy link
Collaborator

fschade commented May 28, 2021 •
edited
Loading

relates to #5130, #5085

@fschade fschade mentioned this issue May 28, 2021
Merged
@kulmann kulmann added Priority:p1-urgent Consider a hotfix release with only that fix and removed Priority:p2-high Escalation, on top of current planning, release blocker p2-high labels May 28, 2021
@pascalwengerter pascalwengerter mentioned this issue Jun 10, 2021
Merged
1 task
@exalate-issue-sync
Copy link
Author

exalate-issue-sync bot commented Jun 11, 2021 •
edited by fschade
Loading

Florian Schade commented: done, but at the moment we do not cancel requests but optimised the whole topic. If cancelation in needed the new HTTPclient is now able to just call cancel() on a request

@exalate-issue-sync exalate-issue-sync bot reopened this Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category:Defect Existing functionality is not working as expected Priority:p1-urgent Consider a hotfix release with only that fix Topic:Hardening Topic:Performance Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[full-ci] Various performance and structure optimizations owncloud/web
2 participants
@kulmann @fschade