Responses are rendered in different places

[labkode]

If I send a request to list a large directory /A/B/C.
In the mean time I change path to /Z.
Request to /A/B/C finished and shows the content of C inside Z.

The expected behaviour is that the response should not be rendered as this is not the original path it was requested.

[pascalwengerter]

@labkode could you check if this is still the case? Should have been fixed by our recent changes

[pascalwengerter]

Closed as fixed (due to various performance improvements) unless @labkode can reproduce

[diocas]

Hi, we managed to reproduce this error again. As described in #5875, loading the / root dir (which takes some time) before loading the homedir, is causing the homedir contents to be replaced. And then this is extremely confusing to users because clicking "All my files" does nothing in this case.

[labkode]

As discussed today this is major issue in general. To short-cut it we need to disable the PROPFIND to root when loading the UI. This is a major issue for the web and I hope it can be fixed without having to change framework.

[labkode]

@kulmann @dragotin
This is a major blocker for our roll-out and needs to be fixed in short-time (days).
By manually testing it you end up with: browsing into a directory and is empty, browsing into a directory that contains contents from other places, clicking on shared with me and listing your home files rather than your shares, etc ...

[kulmann]

@kulmann @dragotin
This is a major blocker for our roll-out and needs to be fixed in short-time (days).
By manually testing it you end up with: browsing into a directory and is empty, browsing into a directory that contains contents from other places, clicking on shared with me and listing your home files rather than your shares, etc ...

Thank you for your comment, I was finally able to reproduce it locally. We only solved edge cases within one view so far (so if you navigate into sub- or parent-folders in the All files list). That all works fine now as far as I know, because those requests are resolved sequentially. BUT: across views requests for loading resources can indeed overlap. So a slow loading "shared with me" will render into a fast loading "All files" view and vice versa. "render" is not 100% correct because there are also some error cases, where you'll see "resource not found". With that I'll shift priority back onto #5892 immediately (now).

[fschade]

@labkode can you please test #5917. Should fix it, i hope i spotted all places.

[diocas]

I've tested it and it looks better. But I still manage to reproduce the issue.

One of the times I reproduced, I don't remember what I did. But I got a "resource not found", like when in the past we switched views (but I might have clicked in an empty folder as well... Don't know).

In another, in the files/list/all, I clicked the breadcrumb to go to a higher level (with takes some time to load), then hit the "back" button of my browser. The route changed, the request started and finished, but the page kept loading, waiting for the upper level request. When that one finished, the page rendered with its contents, but the route+breadcrumb was not matching the content.

This leads me to conclude that although it seems that seeing this issue when switching between views has become hard (or impossible), it's still easy to reproduce when in the same view.

[fschade]

@diocas, good catch, thank you. It was implemented for switchings views, but not for switching a resource in the same view.
I fixed it, can you please have a second look.

[diocas]

@fschade tested and looks ok!

[fschade]

thanks @diocas

[elizavetaRa]

We can reproduce this issue again

[diocas]

ping @kulmann

[kulmann]

Please provide steps to reproduce. If I do what you show in the screen capture, even with throttled connection and large folders, I can't reproduce it.

[dragotin]

Seems fixed, if not @elizavetaRa please reopen.