Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deleted files from search result #3266

Merged
merged 1 commit into from
Apr 27, 2020
Merged

remove deleted files from search result #3266

merged 1 commit into from
Apr 27, 2020

Conversation

karakayasemi
Copy link
Contributor

Description

Deleted file removed from filesSearched state by adding a new mutation. Also, filter condition in remove file mutations changed from object reference to unique file id.

Related Issue

Motivation and Context

How Has This Been Tested?

Applied the described steps in the issues.

Types of changes\

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Mar 26, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@karakayasemi karakayasemi self-assigned this Mar 26, 2020
@karakayasemi karakayasemi force-pushed the fix-delete-from-search branch 5 times, most recently from 7f44dcf to 8a575d8 Compare March 28, 2020 14:52
@karakayasemi karakayasemi force-pushed the fix-delete-from-search branch 2 times, most recently from 96c4566 to 1a8d212 Compare April 24, 2020 06:43
@karakayasemi
Copy link
Contributor Author

Since more than once "lorem-big.txt" in skeleton files, the related test scenario was failing. I have refactored the related scenario by using different file name.

@karakayasemi karakayasemi marked this pull request as ready for review April 24, 2020 07:38
@karakayasemi karakayasemi added the Status:Needs-Review Needs review from a maintainer label Apr 24, 2020
individual-it
individual-it requested changes Apr 24, 2020
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests look good

LukasHirt
LukasHirt requested changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog item pls

@karakayasemi
Copy link
Contributor Author

karakayasemi commented Apr 24, 2020 •
edited
Loading

Changelog item has been added. @individual-it I guess, your change request is unintentional?

@PVince81 PVince81 merged commit fd7f266 into master Apr 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-delete-from-search branch April 27, 2020 05:52
@micbar micbar mentioned this pull request Apr 28, 2020
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@karakayasemi karakayasemi

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File do not disappear from search result after deleting it. Delete file from search result
5 participants
@karakayasemi @CLAassistant @individual-it @LukasHirt @PVince81