Use chunk size and method override from caps #3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
reviewed
Jun 2, 2020
LukasHirt
reviewed
Jun 2, 2020
PVince81
force-pushed
the
tus-use-capability-values
branch
2 times, most recently
from
e8281bc
to
1b852fb
Compare
LukasHirt
reviewed
Jun 2, 2020
LukasHirt
reviewed
Jun 2, 2020
Use the chunk size from the capabilities if it is higher than the locally configured one. Use HTTP method override mode if the TUS capabilities says so.
PVince81
force-pushed
the
tus-use-capability-values
branch
from
1b852fb
to
7569035
Compare
|
I've pushed again, hopefully all should be fine now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the chunk size from the capabilities if it is higher than the
locally configured one.
Use HTTP method override mode if the TUS capabilities says so.
For owncloud/ocis-reva#177.
Requires owncloud/ocis-reva#228 for testing the capabilities
Requires cs3org/reva#792 for testing the method override.
I've tested with the above PRs and the upload is using the correct chunk value and is also setting
overridePatchMethodwhenever the matching capability is set.Note: merging this should be safe due to default values.