[tests-only] Fix expected failures for sharedFolderWithMultipleUsersAdvancedPermissions.feature #4780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
reviewed
Mar 1, 2021
|
|
||
| @issue-ocis-717 | ||
| #after fixing the issue merge this scenario into the one above |
There was a problem hiding this comment.
If this has been merged into the one above, can we drop it?
There was a problem hiding this comment.
yes, actually we could and adjust the expected failures files accordingly. THX
There was a problem hiding this comment.
@LukasHirt
done, please review again
|
Change in the expected failures LGTM 👍 |
individual-it
force-pushed
the
fixExpectedFailures
branch
from
d1be5d0
to
6cb2e90
Compare
dpakach
approved these changes
Mar 1, 2021
|
I restarted CI - there were some unrelated fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issues owncloud/ocis/issues/717 and owncloud/product/issues/203 are closed and the tests actually don't fail because of them so:
How Has This Been Tested?
🤖
Types of changes
Checklist:
Open tasks: