Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minifier): temporarily bail constant folding for tagged template #4842

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Aug 12, 2024

closes #4341

Copy link

graphite-app bot commented Aug 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 12, 2024
Copy link

graphite-app bot commented Aug 12, 2024

Merge activity

  • Aug 12, 3:35 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 12, 3:37 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Aug 12, 3:41 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@github-actions github-actions bot added the A-minifier Area - Minifier label Aug 12, 2024
@Boshen Boshen force-pushed the 08-12-fix_minifier_temporarily_bail_constant_folding_for_tagged_template branch from 8784016 to fae8a62 Compare August 12, 2024 07:38
@graphite-app graphite-app bot merged commit fae8a62 into main Aug 12, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 08-12-fix_minifier_temporarily_bail_constant_folding_for_tagged_template branch August 12, 2024 07:41
Copy link

codspeed-hq bot commented Aug 12, 2024

CodSpeed Performance Report

Merging #4842 will not alter performance

Comparing 08-12-fix_minifier_temporarily_bail_constant_folding_for_tagged_template (fae8a62) with main (955a4b4)

Summary

✅ 29 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Compressor|RemoveDeadCode]: Wrong simplified expression in the tagged template
1 participant