feat(linter): implement no-throw-literal

[shulaoda]

Related to #479

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[codspeed-hq]

CodSpeed Performance Report

Merging #6144 will not alter performance

_{Comparing shulaoda:feat/no-throw-literal (a00d04a) with main (02fedf5)}

Summary

✅ 29 untouched benchmarks

[camchenry]

Could we add help text for this? Like:

• Wrap the value with an error object: `throw new Error(...)`
  

• or if undefined:

  throw an error object instead: `throw new Error()`
  

[shulaoda]

Currently, there are many rules that do not provide help, only help prompts when fixable.

Wrap the value with an error object: throw new Error(...)

For fixable types like string and template, they automatically include help suggestions. We've already implemented fixes for some of them, and the remaining ones are largely unfixable, so this prompt might not be necessary.

throw an error object instead: throw new Error()

For undefined, this should be a very intuitive error prompt in itself, and perhaps help is not necessary.

Is there a necessary requirement for adding help? Under what circumstances should we add it? @DonIsaac

[camchenry]

consider this comment as non-blocking. I'm of the opinion that every warning/error should include at least some indication of how to fix it. I think a static message here would be fine too:

.with_help("Throw an Error object instead: `throw new Error()`")

Some diagnostics don't contain help messages, I would consider that something we should fix. From our Linter Rule principles:

• The message should be an imperative statement about what is wrong, not a description of what the rule does.
• The help message should be a command-like statement that tells the user how to fix the issue.