Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Standardised Quoted Message Behaviour #2399

Closed
wants to merge 16 commits into from

Conversation

yougotwill
Copy link
Collaborator

@yougotwill yougotwill commented Jul 29, 2022

Description

Makes the current behaviour of quoted message handling the same as mobile. We should probably merge this after ID blinding

Changes

  • When a quote is shown the original message content is fetched from the database. It is no longer sent as data alongside the DataMessage.
  • If the original message cannot be found then the text "Original message not found" is shown in all cases including if there was previously an attachment.
  • The Original message's author should be on the first line, followed by a single line of quoted content (truncated with an elipsis).
  • The quoted content should be wrapped based on the width of the quoted content. The is a minimum and maximum width for both quoted content and regular messages. Further explanation below.
    • if the quoted content is longer than the reply then the message box should expand to the maximum allowed width of a message box
    • If the quoted content and reply are long then the message can grow to the maximum allowed width of a message box
    • if the reply is very short and the quoted content is long the message width is the minimum allowed width for a message box.
  • Updated linkify-it dependency
  • removed duplicate getMessageBySenderAndSentAt function and replaced any calls with getMessageBySenderAndTimestamp
  • Updated EmojiSize to use default by default instead of small.

This PR will allow us to close #2343 as well.

@yougotwill yougotwill changed the title Standardised Quoted Message Behaviour [WIP] Standardised Quoted Message Behaviour Jul 29, 2022
@yougotwill yougotwill changed the title [WIP] Standardised Quoted Message Behaviour Standardised Quoted Message Behaviour Jul 29, 2022
@ianmacd
Copy link

ianmacd commented Jul 30, 2022

The statement:

  • if the quoted content is longer than the reply then the message box should expand to the maximum allowed width of a message box

and the statement:

  • if the reply is very short and the quoted content is long the message width is the minimum allowed width for a message box.

appear to at least partially contradict one another.

@yougotwill yougotwill changed the title Standardised Quoted Message Behaviour [WIP] Standardised Quoted Message Behaviour Aug 1, 2022
@Bilb Bilb marked this pull request as draft August 26, 2022 03:00
@Bilb
Copy link
Collaborator

Bilb commented May 12, 2023

an updated PR of this is being worked on by @yougotwill atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants