Opengroup Poller Reaction Conflict Resolution + Fixes #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yougotwill
commented
Aug 29, 2022
•
yougotwill
commented
- Created a cache for opengroup reactions, which we use to create an "optimistic" state for message reactions in an opengroup (this compares local state vs server state and resolves).
- Added more information about the current number of reactors for an opengroup message when viewing the Reaction List Modal
- Fixed reaction Notifications for 1-1 conversations.
- In opengroups, when sending a reaction or clearing a reaction we update the local state triggering a UI update when the message is sent and if anything failed it will be resolved by the poll update since we overwrite all local state of reactions in open groups. This improves the perceived responsiveness of reacting to a message or moderators clearing a reaction.
cached entries are now added or removed based on the "optimistic" state that we want
Bilb
reviewed
Aug 29, 2022
yougotwill
changed the title
updated idForLogging for opengroups to be more verbose, updated reaction method calls to use exported Reactions object
refactored processMessagesWithCachce function
yougotwill
commented
Aug 31, 2022
Bilb
reviewed
Aug 31, 2022
yougotwill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.