Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed Reaction text alignment in the React List modal #2474

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

yougotwill
Copy link
Collaborator

This is pretty nuanced, but when we have flex nowrap the descendants can be squished so we have to force no wrapping.

this is pretty nuanced, when we have flex nowrap the descendants can be squished so we have to force no wrapping
@Bilb
Copy link
Collaborator

Bilb commented Sep 6, 2022

lgtm

@ianmacd
Copy link

ianmacd commented Sep 6, 2022

This is pretty nuanced, but when we have flex nowrap the descendants can be squished so we have to force no wrapping.

Should that modal have an X to explicitly close it? One can simply click outside the modal to close it, I know, but my intuition expects a close button on a modal that resembles an ordinary dialogue window.

@Bilb Bilb merged commit cdb010a into oxen-io:clearnet Sep 6, 2022
@yougotwill yougotwill deleted the react_modal_alignment_fix branch February 27, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants