forked from signalapp/Signal-Desktop
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merging disappear v2 to clearnet #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we dont want individual padding on each message type
I have broken the reverse flexbox
tested different modes
the last commit was actually for changeToDisappearingConversationMode
part of the protobuf utils
when testing we dont want to commit the timer update message
to generateDisappearingVisibleMessage
added generateFakeExpirationTimerUpdate for testing
added tests for buildExpireRequest
…der_shadow SES 1409, 579, 714
Fix expiration read another device
so we dont need options in the delete modal
fix: make onClickClose on confirmModal mandatory
highlighting should only happen when a message is right clicked
…lete SES-1434 fix: note to self convos cannot delete for everyone
…ight_panel SES-1438: fix: dont show admin crown in message info screen
…e_reactions SES-1440: fix: dont display reacts when viewing a message in the right panel
…sage_highlight SES-1441 fix: if we are in multiselect mode dont highlight the message
fix: text in msg ctx menu disappearing timer
fix: show timer fixed when off update
Fix qa issues disappear v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.