Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: legacy groups are unapproved so should allow all notifications #3066

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix: legacy groups are unapproved so should allow all notifications #3066

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3c80ad
fix: legacy groups are unapproved so should allow all notifications
yougotwill Apr 4, 2024
a139299
fix: review feedback
yougotwill Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ts/models/conversation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,9 +1739,11 @@ export class ConversationModel extends Backbone.Model<ConversationAttributes> {
return;
}
const conversationId = this.id;
const isLegacyGroup = this.isGroup() && !this.isPublic() && this.id.startsWith('05');
Bilb marked this conversation as resolved.
Show resolved Hide resolved

let friendRequestText;
if (!this.isApproved()) {
// NOTE: legacy groups are never approved, so we don't should not cancel notifications
Bilb marked this conversation as resolved.
Show resolved Hide resolved
if (!this.isApproved() && !isLegacyGroup) {
window?.log?.info('notification cancelled for unapproved convo', this.idForLogging());
const hadNoRequestsPrior =
getConversationController()
Expand Down
Loading