Arm64 now builds locally from source #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we still have an issue with building on ci
Bilb
reviewed
May 2, 2024
| @@ -29,7 +29,7 @@ exports.default = async function notarizing(context) { | |||
| } | |||
|
|
|||
| const options = { | |||
| appBundleId: 'org.getsession.desktop', | |||
There was a problem hiding this comment.
is this a required change? I am not sure I want to touch the notarizing logic,
There was a problem hiding this comment.
So the thing is our appId in the package.json is this already. The other platforms also use this id. This script is the outlier. I have confirmed it doesn't break anything on mac.
There was a problem hiding this comment.
Actually we might be able to remove this entirely since it is no longer used https://www.electron.build/configuration/mac.html#notarizelegacyoptions
There was a problem hiding this comment.
well it's on the legacy list of options which doesn't mean it's not used. We want still be on the legacy options for other things, but ok.
|
lgtrm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still have an issue with building on ci.
See #3058