Skip to content

Commit

Permalink
[nexus] [trivial] Clean up periods, capitalization, articles in inter…
Browse files Browse the repository at this point in the history
…net gateways API docs (#6792)
  • Loading branch information
david-crespo authored Oct 7, 2024
1 parent f3ab338 commit dda39e3
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 21 deletions.
12 changes: 6 additions & 6 deletions common/src/api/external/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1570,9 +1570,9 @@ pub struct RouterRoute {
pub vpc_router_id: Uuid,
/// Describes the kind of router. Set at creation. `read-only`
pub kind: RouterRouteKind,
/// The location that matched packets should be forwarded to.
/// The location that matched packets should be forwarded to
pub target: RouteTarget,
/// Selects which traffic this routing rule will apply to.
/// Selects which traffic this routing rule will apply to
pub destination: RouteDestination,
}

Expand All @@ -1581,9 +1581,9 @@ pub struct InternetGatewayIpPool {
/// Common identifying metadata
#[serde(flatten)]
pub identity: IdentityMetadata,
/// The ID of the internet gateway to which the IP pool entry belongs.
/// The ID of the internet gateway to which the IP pool entry belongs
pub internet_gateway_id: Uuid,
/// The ID of the referenced IP pool.
/// The ID of the referenced IP pool
pub ip_pool_id: Uuid,
}

Expand All @@ -1592,9 +1592,9 @@ pub struct InternetGatewayIp {
/// Common identifying metadata
#[serde(flatten)]
pub identity: IdentityMetadata,
/// The ID of the internet gateway to which the IP belongs.
/// The ID of the internet gateway to which the IP belongs
pub internet_gateway_id: Uuid,
/// The IP address.
/// The IP address
pub address: IpAddr,
}

Expand Down
14 changes: 7 additions & 7 deletions nexus/external-api/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2257,7 +2257,7 @@ pub trait NexusExternalApi {
query_params: Query<params::InternetGatewayDeleteSelector>,
) -> Result<HttpResponseDeleted, HttpError>;

/// List IP pools attached to an internet gateway.
/// List IP pools attached to internet gateway
#[endpoint {
method = GET,
path = "/v1/internet-gateway-ip-pools",
Expand All @@ -2273,7 +2273,7 @@ pub trait NexusExternalApi {
HttpError,
>;

/// Attach ip pool to internet gateway
/// Attach IP pool to internet gateway
#[endpoint {
method = POST,
path = "/v1/internet-gateway-ip-pools",
Expand All @@ -2285,7 +2285,7 @@ pub trait NexusExternalApi {
create_params: TypedBody<params::InternetGatewayIpPoolCreate>,
) -> Result<HttpResponseCreated<views::InternetGatewayIpPool>, HttpError>;

/// Detach ip pool from internet gateway
/// Detach IP pool from internet gateway
#[endpoint {
method = DELETE,
path = "/v1/internet-gateway-ip-pools/{pool}",
Expand All @@ -2297,7 +2297,7 @@ pub trait NexusExternalApi {
query_params: Query<params::DeleteInternetGatewayElementSelector>,
) -> Result<HttpResponseDeleted, HttpError>;

/// List addresses attached to an internet gateway.
/// List IP addresses attached to internet gateway
#[endpoint {
method = GET,
path = "/v1/internet-gateway-ip-addresses",
Expand All @@ -2313,7 +2313,7 @@ pub trait NexusExternalApi {
HttpError,
>;

/// Attach ip pool to internet gateway
/// Attach IP pool to internet gateway
#[endpoint {
method = POST,
path = "/v1/internet-gateway-ip-addresses",
Expand All @@ -2325,7 +2325,7 @@ pub trait NexusExternalApi {
create_params: TypedBody<params::InternetGatewayIpAddressCreate>,
) -> Result<HttpResponseCreated<views::InternetGatewayIpAddress>, HttpError>;

/// Detach ip pool from internet gateway
/// Detach IP pool from internet gateway
#[endpoint {
method = DELETE,
path = "/v1/internet-gateway-ip-addresses/{address}",
Expand Down Expand Up @@ -3173,6 +3173,6 @@ pub fn validate_api(spec: &OpenAPI, mut cx: ValidationContext<'_>) {
pub type IpPoolRangePaginationParams =
PaginationParams<EmptyScanParams, IpNetwork>;

/// Type used to paginate request to list timeseries schema.
/// Type used to paginate request to list timeseries schema
pub type TimeseriesSchemaPaginationParams =
PaginationParams<EmptyScanParams, oximeter_types::TimeseriesName>;
16 changes: 8 additions & 8 deletions openapi/nexus.json
Original file line number Diff line number Diff line change
Expand Up @@ -2681,7 +2681,7 @@
"tags": [
"vpcs"
],
"summary": "List addresses attached to an internet gateway.",
"summary": "List IP addresses attached to internet gateway",
"operationId": "internet_gateway_ip_address_list",
"parameters": [
{
Expand Down Expand Up @@ -2764,7 +2764,7 @@
"tags": [
"vpcs"
],
"summary": "Attach ip pool to internet gateway",
"summary": "Attach IP pool to internet gateway",
"operationId": "internet_gateway_ip_address_create",
"parameters": [
{
Expand Down Expand Up @@ -2828,7 +2828,7 @@
"tags": [
"vpcs"
],
"summary": "Detach ip pool from internet gateway",
"summary": "Detach IP pool from internet gateway",
"operationId": "internet_gateway_ip_address_delete",
"parameters": [
{
Expand Down Expand Up @@ -2891,7 +2891,7 @@
"tags": [
"vpcs"
],
"summary": "List IP pools attached to an internet gateway.",
"summary": "List IP pools attached to internet gateway",
"operationId": "internet_gateway_ip_pool_list",
"parameters": [
{
Expand Down Expand Up @@ -2974,7 +2974,7 @@
"tags": [
"vpcs"
],
"summary": "Attach ip pool to internet gateway",
"summary": "Attach IP pool to internet gateway",
"operationId": "internet_gateway_ip_pool_create",
"parameters": [
{
Expand Down Expand Up @@ -3038,7 +3038,7 @@
"tags": [
"vpcs"
],
"summary": "Detach ip pool from internet gateway",
"summary": "Detach IP pool from internet gateway",
"operationId": "internet_gateway_ip_pool_delete",
"parameters": [
{
Expand Down Expand Up @@ -18674,7 +18674,7 @@
"type": "string"
},
"destination": {
"description": "Selects which traffic this routing rule will apply to.",
"description": "Selects which traffic this routing rule will apply to",
"allOf": [
{
"$ref": "#/components/schemas/RouteDestination"
Expand Down Expand Up @@ -18703,7 +18703,7 @@
]
},
"target": {
"description": "The location that matched packets should be forwarded to.",
"description": "The location that matched packets should be forwarded to",
"allOf": [
{
"$ref": "#/components/schemas/RouteTarget"
Expand Down

0 comments on commit dda39e3

Please sign in to comment.