Skip to content

Commit

Permalink
add explanatory comments
Browse files Browse the repository at this point in the history
  • Loading branch information
gjcolombo committed Jul 31, 2024
1 parent 88b6b9a commit 36c8379
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
11 changes: 11 additions & 0 deletions .github/buildomat/jobs/phd-run-migrate-from-base.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,17 @@
#: job = "phd-build"
#:

# This job runs the PHD migrate-from-base tests, which test upgrading from the
# current mainline propolis-server to the propolis-server version under test.
#
# PHD always uses the propolis-client from the commit under test, so these tests
# will fail if there is a breaking change to the Propolis API. They'll also fail
# if there's a breaking change to the migration protocol. These changes may be
# expected, in which case this run will fail. However, the "regular" phd-run
# job should always be green before merging new PRs.
#
# This job will be removed once API breaking changes are no longer allowed.

cp /input/phd-build/out/phd-run-with-args.sh /tmp/phd-run-with-args.sh
chmod a+x /tmp/phd-run-with-args.sh
exec /tmp/phd-run-with-args.sh \
Expand Down
6 changes: 6 additions & 0 deletions .github/buildomat/jobs/phd-run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@
#: job = "phd-build"
#:

# This job runs all the PHD test cases that don't involve upgrading from an
# earlier version of Propolis.
#
# These tests should always pass even in the presence of breaking changes to the
# Propolis API or live migration protocol.

cp /input/phd-build/out/phd-run-with-args.sh /tmp/phd-run-with-args.sh
chmod a+x /tmp/phd-run-with-args.sh
exec /tmp/phd-run-with-args.sh --exclude-filter "phd_tests::migrate::from_base"

0 comments on commit 36c8379

Please sign in to comment.