refactor: move config TOML parsing into a submodule #737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Part 2 in the instance spec refactoring series; see #735.)
Move large parts of the config TOML parsing logic in server spec builder into their own module. The parsing logic is functionally the same; the main difference is that there's a new, more descriptive error type (
ConfigTomlError
) that converts to aServerSpecBuilderError
variant instead of a variant that just takes aString
. The idea is eventually to have separate modules for parsing config TOMLs,InstanceEnsureRequest
s, andVersionedInstanceSpec
s; this is the first small step in that direction.Tests: PHD, cargo test, ad hoc propolis-server testing; launched a Falcon topology and verified by hitting the
/instance/spec
endpoint that it created all the correct devices.