Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHD: add support for in-memory disk backends #740

Merged
merged 7 commits into from
Aug 9, 2024

Conversation

gjcolombo
Copy link
Contributor

Add an affordance for creating in-memory disk backends in PHD and populating them with data in a FAT filesystem (similar to what propolis-standalone and omicron do to create cloud-init data volumes). Add a small test that such volumes can be mounted and read as expected.

A future PR will use this for integration testing of #301, but this stands alone so thought I would put it up as its own PR.

Add an affordance for creating in-memory disk backends in PHD and
populating them with data in a FAT filesystem (similar to what
propolis-standalone and omicron do to create cloud-init data volumes).
Add a small test that such volumes can be mounted and read as expected.
@gjcolombo gjcolombo added storage Related to storage devices/backends. testing Related to testing and/or the PHD test framework. labels Aug 7, 2024
phd-tests/framework/src/disk/fat.rs Outdated Show resolved Hide resolved
phd-tests/framework/src/disk/mod.rs Outdated Show resolved Hide resolved
phd-tests/framework/src/disk/mod.rs Outdated Show resolved Hide resolved
@gjcolombo gjcolombo requested a review from hawkw August 9, 2024 21:26
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some last obnoxious nitpicks, but no blockers from me!

phd-tests/framework/src/disk/mod.rs Outdated Show resolved Hide resolved
phd-tests/framework/src/disk/mod.rs Outdated Show resolved Hide resolved
phd-tests/framework/src/disk/fat.rs Outdated Show resolved Hide resolved
phd-tests/framework/src/disk/fat.rs Show resolved Hide resolved
phd-tests/framework/src/disk/fat.rs Outdated Show resolved Hide resolved
@gjcolombo gjcolombo force-pushed the gjcolombo/phd-in-memory-disk-backend branch from 113adc1 to 3e77600 Compare August 9, 2024 23:04
@gjcolombo gjcolombo merged commit 5e46c25 into master Aug 9, 2024
11 checks passed
@gjcolombo gjcolombo deleted the gjcolombo/phd-in-memory-disk-backend branch August 9, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage Related to storage devices/backends. testing Related to testing and/or the PHD test framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants