update to hyper v1 #745
Merged
update to hyper v1 #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pfmooney I'm going to update this with the progenitor and dropshot dependencies that I'm working on landing, but I was hoping you could get eyes on this |
pfmooney
reviewed
Sep 26, 2024
| @@ -14,10 +14,10 @@ use std::sync::Arc; | |||
| use std::time::Duration; | |||
|
|
|||
| use crate::serial::history_buffer::{HistoryBuffer, SerialHistoryOffset}; | |||
| use dropshot::WebsocketConnectionRaw; | |||
There was a problem hiding this comment.
Why the use here, when the later references are made to dropshot::WebsocketConnectionRaw, rather than the bare name?
There was a problem hiding this comment.
um... bad programming? I'll fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.