Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multipart requests sending json header #22

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Fix multipart requests sending json header #22

merged 4 commits into from
Jun 23, 2022

Conversation

augustuswm
Copy link
Contributor

@augustuswm augustuswm commented Jun 15, 2022 •
edited
Loading

This update contains two main fixes:

  1. Functions that send form requests no longer set the Content-Type: application/json header.
  2. Retry logic is disabled for streaming requests. Streaming requests are not currently supported by the retry middleware.

@augustuswm augustuswm merged commit f92b84b into main Jun 23, 2022
@augustuswm augustuswm deleted the fix-multipart branch June 23, 2022 13:29
oxypwn pushed a commit to percent20/third-party-api-clients that referenced this pull request Aug 9, 2022
@augustuswm @oxypwn
Fix multipart requests sending json header (oxidecomputer#22)
c98248b 
* Fix multipart requests sending json header

* Point retry middleware at fork

* Add streaming passthrough

* Switch to conditional middleware
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@augustuswm