disable chrono default-features #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding this. I'll work on getting the remaining clients updated so they no longer activate the feature. |
kavin-kr
pushed a commit
to kavin-kr/third-party-api-clients
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chrono 0.4, for legacy reasons, has a dependency on time 0.1. time 0.1 has the potential for CVE-2020-26235.
This dependency can be avoided by turning off the default features. The build succeeds after changing this and disabling the Google clients (which use another library that brings in the default features I'm trying to avoid) so it looks like the other features were not being used directly here.