[github] add default derive for MinimalRepository and WorkflowRun #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@augustuswm do you have any opinions on this? |
|
Yes, sorry for not following up on this. This makes sense to me. I'll try to get this merged and released early this week. |
|
Thanks for the quick reply. Let me actually update it with another struct I would have otherwise have to wrap. |
…heckAnnotation When instanciating those in test, the number of fields that needs to be declared is overwhelming. When dealing with test cases, in many cases, only a few fields really matter and having something to populate defaults avoid lots of boiler plate.
chantra
force-pushed
the
default_workflowrun_minimalrepo_struct
branch
from
056ce88
to
4605f03
Compare
|
I'm good with merging these additions. Let me know if you have all of the needed types covered. I'll see if we can have a better way of doing this then listing all of the types. |
|
Yes, I should be good for now. Thanks for checking @augustuswm . |
kavin-kr
pushed a commit
to kavin-kr/third-party-api-clients
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When instanciating those in test, the number of fields that needs to be declared is overwhelming. When dealing with test cases, in many cases, only a few fields really matter and having something to populate defaults avoid lots of boiler plate.