Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/go-chi/chi to v5 #158

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 28, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
github.com/go-chi/chi require major v4.1.2+incompatible -> v5.0.0

Release Notes

go-chi/chi

v5.0.0

Compare Source

  • chi v5, github.com/go-chi/chi/v5 introduces the adoption of Go's SIV to adhere to the current state-of-the-tools in Go.
  • chi v1.5.x did not work out as planned, as the Go tooling is too powerful and chi's adoption is too wide.
    The most responsible thing to do for everyone's benefit is to just release v5 with SIV, so I present to you all,
    chi v5 at github.com/go-chi/chi/v5. I hope someday the developer experience and ergonomics I've been seeking
    will still come to fruition in some form, see golang/go#​44550
  • History of changes: see go-chi/chi@v1.5.4...v5.0.0

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@oxyno-zeta
Copy link
Owner

Declined due to go-chi/chi#592

@oxyno-zeta oxyno-zeta closed this Feb 28, 2021
@renovate
Copy link
Contributor Author

renovate bot commented Feb 28, 2021

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 5.x releases. However, if you upgrade to 5.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/github.com-go-chi-chi-5.x branch February 28, 2021 14:19
@@ -10,7 +10,8 @@ require (
github.com/dimiro1/health v0.0.0-20191019130555-c5cbb4d46ffc
github.com/dustin/go-humanize v1.0.0
github.com/fsnotify/fsnotify v1.4.9
github.com/go-chi/chi v4.1.2+incompatible
github.com/go-chi/chi v1.5.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue appears to be here, you should remove v1.5.1 and only use chi/v5 now

@pkieltyka
Copy link

You will need to rename all import paths from "github.com/go-chi/chi" to "github.com/go-chi/chi/v5" -- yeay SIV

@oxyno-zeta
Copy link
Owner

Ok thanks for your feedback @pkieltyka . I will try to do this after working on my actual feature of managing cache and ETag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants