Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Wikimedia" to "Mediawiki" and other minor fixes #40

Merged
merged 3 commits into from
Jan 13, 2019

Conversation

waldyrious
Copy link
Contributor

Wikimedia is the umbrella project that includes Wikipedia, Wiktionary, etc. The markup itself is actually called MediaWiki code, or just wikicode, and it is used by all wikis that are based in the same software, including many that are not Wikimedia projects.

This PR also adds a code example for mediawiki tables to the README, as well as small whitespace fixes.

Wikimedia is the umbrella project that includes Wikipedia, Wiktionary, etc.
The markup itself is actually called MediaWiki code, or just wikicode,
and it is used by all wikis that are based in the same software,
including many that are not Wikimedia projects.
@ozh
Copy link
Owner

ozh commented Jan 13, 2019

Pull request pro tip: don't bury the point of your PR (here: rename to mediawiki & add an example) into a 100 line commit because you're also randomly modifying white space. I wish Github would allow to easily cherry picking commits from a pull request.

@ozh ozh merged commit f58cfb4 into ozh:gh-pages Jan 13, 2019
@waldyrious
Copy link
Contributor Author

waldyrious commented Jan 13, 2019

a 100 line commit

@ozh I'm not sure I follow -- I specifically submitted the PR with 3 separate commits, all atomic in the changes they made and with informative messages. The diff for each commit can be seen individually using the "Commits" tab of the pull request.

I apologize if I misunderstood what you meant. Please clarify if that's the case.

@waldyrious waldyrious deleted the mediawiki branch January 13, 2019 21:37
@ozh
Copy link
Owner

ozh commented Jan 13, 2019

Yes, you can see individual commits but cannot (through the web interface) cherry pick commits (ie approve only specific commits). A good practice is to make PR have one feature (or bug fix or whatever)

@waldyrious
Copy link
Contributor Author

@ozh as I see it, that's what PR review is for :) if you had asked me to drop some of the commits, or change something else, I would gladly have updated the PR branch.

A good practice is to make PR have one feature (or bug fix or whatever)

I agree. It's sometimes a fine line between what's a small enough change (and close enough to the rest of the diff) to be considered as a mere side-effect of the "actual" changes, and what's a more global-scale cleanup that would warrant a separate PR. In this case it started as the former but I admit it scaled up to the latter. Sorry about that -- I'll make sure to make a cleaner separation next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants