Skip to content

Commit

Permalink
Reenable CI coverage (nushell#8867)
Browse files Browse the repository at this point in the history
# Description
Let's see if we don't run out of disk space as quickly again

This reverts commit 0e496f9.
(nushell#8677)



# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting

Same coverage setup as before
  • Loading branch information
sholderbach committed Apr 13, 2023
1 parent 36036d9 commit b9808c8
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 38 deletions.
74 changes: 37 additions & 37 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -169,40 +169,40 @@ jobs:
run: cargo test --profile ci --package nu_plugin_*


# nu-coverage:
# needs: nu-tests
# env:
# NUSHELL_CARGO_TARGET: ci

# strategy:
# fail-fast: true
# matrix:
# # disabled mac due to problems with merging coverage and similarity to linux
# # disabled windows due to running out of disk space when having too many crates or tests
# platform: [ubuntu-20.04] # windows-latest
# rust:
# - stable

# runs-on: ${{ matrix.platform }}

# steps:
# - uses: actions/checkout@v3

# - name: Setup Rust toolchain and cache
# uses: actions-rust-lang/setup-rust-toolchain@v1.4.4
# - name: Install cargo-llvm-cov
# uses: taiki-e/install-action@cargo-llvm-cov

# - name: Tests
# shell: bash
# run: |
# source <(cargo llvm-cov show-env --export-prefix) # Set the environment variables needed to get coverage.
# cargo llvm-cov clean --workspace # Remove artifacts that may affect the coverage results.
# cargo build --workspace --profile ci
# cargo test --workspace --profile ci
# cargo llvm-cov report --profile ci --lcov --output-path lcov.info

# - name: Upload coverage reports to Codecov with GitHub Action
# uses: codecov/codecov-action@v3
# with:
# files: lcov.info
nu-coverage:
needs: nu-tests
env:
NUSHELL_CARGO_TARGET: ci

strategy:
fail-fast: true
matrix:
# disabled mac due to problems with merging coverage and similarity to linux
# disabled windows due to running out of disk space when having too many crates or tests
platform: [ubuntu-20.04] # windows-latest
rust:
- stable

runs-on: ${{ matrix.platform }}

steps:
- uses: actions/checkout@v3

- name: Setup Rust toolchain and cache
uses: actions-rust-lang/setup-rust-toolchain@v1.4.4
- name: Install cargo-llvm-cov
uses: taiki-e/install-action@cargo-llvm-cov

- name: Tests
shell: bash
run: |
source <(cargo llvm-cov show-env --export-prefix) # Set the environment variables needed to get coverage.
cargo llvm-cov clean --workspace # Remove artifacts that may affect the coverage results.
cargo build --workspace --profile ci
cargo test --workspace --profile ci
cargo llvm-cov report --profile ci --lcov --output-path lcov.info
- name: Upload coverage reports to Codecov with GitHub Action
uses: codecov/codecov-action@v3
with:
files: lcov.info
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
[![@nu_shell](https://img.shields.io/badge/twitter-@nu_shell-1DA1F3?style=flat-square)](https://twitter.com/nu_shell)
[![GitHub commit activity](https://img.shields.io/github/commit-activity/m/nushell/nushell)](https://github.com/nushell/nushell/graphs/commit-activity)
[![GitHub contributors](https://img.shields.io/github/contributors/nushell/nushell)](https://github.com/nushell/nushell/graphs/contributors)
<!-- [![codecov](https://codecov.io/gh/nushell/nushell/branch/main/graph/badge.svg?token=JheS8qu2II)](https://codecov.io/gh/nushell/nushell) -->
[![codecov](https://codecov.io/gh/nushell/nushell/branch/main/graph/badge.svg?token=JheS8qu2II)](https://codecov.io/gh/nushell/nushell)

A new type of shell.

Expand Down

0 comments on commit b9808c8

Please sign in to comment.